/* * FindBugs - Find Bugs in Java programs * Copyright (C) 2005, University of Maryland * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ package edu.umd.cs.findbugs.detect; import org.apache.bcel.classfile.Code; import org.apache.bcel.classfile.JavaClass; import edu.umd.cs.findbugs.BugAccumulator; import edu.umd.cs.findbugs.BugInstance; import edu.umd.cs.findbugs.BugReporter; import edu.umd.cs.findbugs.BytecodeScanningDetector; import edu.umd.cs.findbugs.ba.ch.Subtypes2; import edu.umd.cs.findbugs.internalAnnotations.DottedClassName; /** * @author pugh */ public class DoInsideDoPrivileged extends BytecodeScanningDetector { BugAccumulator bugAccumulator; public DoInsideDoPrivileged(BugReporter bugReporter) { this.bugAccumulator = new BugAccumulator(bugReporter); } boolean isDoPrivileged = false; @Override public void visit(JavaClass obj) { isDoPrivileged = Subtypes2.instanceOf(getDottedClassName(), "java/security/PrivilegedAction") || Subtypes2.instanceOf(getDottedClassName(), "java/security/PrivilegedExceptionAction"); } @Override public void visit(Code obj) { if (isDoPrivileged && getMethodName().equals("run")) return; if (getMethod().isPrivate()) return; if (DumbMethods.isTestMethod(getMethod())) return; super.visit(obj); bugAccumulator.reportAccumulatedBugs(); } @Override public void sawOpcode(int seen) { if (seen == INVOKEVIRTUAL && getNameConstantOperand().equals("setAccessible")) { @DottedClassName String className = getDottedClassConstantOperand(); if (className.equals("java.lang.reflect.Field") || className.equals("java.lang.reflect.Method")) bugAccumulator.accumulateBug( new BugInstance(this, "DP_DO_INSIDE_DO_PRIVILEGED", LOW_PRIORITY).addClassAndMethod(this) .addCalledMethod(this), this); } if (seen == NEW) { @DottedClassName String classOfConstructedClass = getDottedClassConstantOperand(); if (Subtypes2.instanceOf(classOfConstructedClass, "java/lang/ClassLoader") && !(getMethodName().equals("main") && getMethodSig().equals("([Ljava/lang/String;)V") && getMethod() .isStatic())) bugAccumulator.accumulateBug(new BugInstance(this, "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED", NORMAL_PRIORITY) .addClassAndMethod(this).addClass(classOfConstructedClass), this); } } }